Skip to content

Conversation

apiraino
Copy link
Contributor

@apiraino apiraino commented Oct 9, 2025

Sister patch of triagebot#2191
Follow-up to #147263

The triagebot now triggers a different message when a PR is nominated for backport, making it look like more a suggestion to evaluate for the author/reviewers than a mandatory decision for the team to take.

The wording (as per triagebot#2191) is open to suggestions.

Thanks

@apiraino apiraino force-pushed the update-beta-nom-zulip-msg branch from b69b451 to c340aa0 Compare October 9, 2025 15:23
@rustbot
Copy link
Collaborator

rustbot commented Oct 9, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Oct 9, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 9, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@apiraino apiraino force-pushed the update-beta-nom-zulip-msg branch 2 times, most recently from e4c6a54 to dcb6bce Compare October 9, 2025 15:29
@apiraino
Copy link
Contributor Author

apiraino commented Oct 9, 2025

maybe r? @Kobzol

(as soon as GitHub starts working again)

@rustbot rustbot assigned Kobzol and unassigned Mark-Simulacrum Oct 9, 2025
@Kobzol
Copy link
Member

Kobzol commented Oct 10, 2025

We can always change the wording later, the current wording is fine by me.

@apiraino
Copy link
Contributor Author

r? compiler

(for someone to approve and merge 🙂 )

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 13, 2025
@rustbot rustbot assigned jackh726 and unassigned Kobzol Oct 13, 2025
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to send one comment. I was mostly waiting for other people to chime in, but if no one has a comment in a ~day, you can r=me.

@bors delegate+

View changes since this review

triagebot.toml Outdated
@@ -759,6 +765,7 @@ zulip_stream = 474880 # #t-compiler/backports
topic = "#{number}: beta-nominated"
message_on_add = "PR #{number} has been **accepted** for **beta** backport."

# This is disabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just remove this if it doesn't do anything. We can always create it again in the future if we redesign how it works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those really disabled? I don't see anything in the triagebot changes that makes them disabled. So same as @Kobzol comment, let's actually remove them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable auto-nomination was disabled in #147263 so I thought it was confusing having these bits of configuration which do nothing.

But OK I will remove the comment.

@apiraino apiraino force-pushed the update-beta-nom-zulip-msg branch from dcb6bce to de67ea3 Compare October 15, 2025 10:47
@apiraino
Copy link
Contributor Author

@bors r=Kobzol rollup

@bors
Copy link
Collaborator

bors commented Oct 15, 2025

📌 Commit de67ea3 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 15, 2025
…, r=Kobzol

Update t-compiler beta nomination Zulip msg

Sister patch of [triagebot#2191](rust-lang/triagebot#2191)
Follow-up to rust-lang#147263

The triagebot now triggers a different message when a PR is nominated for backport, making it look like more a suggestion to evaluate for the author/reviewers than a mandatory decision for the team to take.

The wording (as per [triagebot#2191](rust-lang/triagebot#2191)) is open to suggestions.

Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants